david-swift/duckling
1
0
Fork 3
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

fix-extra-linebreak #9

Merged
david-swift merged 3 commits from Tortellini/duckling:fix-extra-linebreak into main 2025-08-26 12:23:55 +02:00
Conversation 4 Commits 3 Files Changed 1 +3 -1
Tortellini commented 2025-08-25 06:29:15 +02:00
Contributor
Copy Link

Hi there,

I really love your more minimalist zola theme! This little bug bothered me though, but this should fix it. It can be seen here, where if you hover over the text "Release 0.1.1", the linebreak will disappear, and stay remain removed until the page is refreshed.

I also realigned the on hover arrow element to be in line with the text as well, but let me know if this isn't what you're looking for.

Hi there, I really love your more minimalist zola theme! This little bug bothered me though, but this should fix it. It can be seen [here](https://duckling.aparoksha.dev/blog/), where if you hover over the text "Release 0.1.1", the linebreak will disappear, and stay remain removed until the page is refreshed. I also realigned the on hover arrow element to be in line with the text as well, but let me know if this isn't what you're looking for.
Tortellini added 2 commits 2025-08-25 06:29:16 +02:00
Tortellini requested review from david-swift 2025-08-25 06:29:16 +02:00
david-swift reviewed 2025-08-26 06:55:16 +02:00
sass/_article-list.scss Outdated
@ -71,3 +73,4 @@
display: inline-block;
position: relative;
transform: translateX(-0.25rem);
top: 0.1rem;
david-swift commented 2025-08-26 06:55:15 +02:00
Owner
Copy Link

Hm, this misaligns the arrow for me on GNOME Web/Firefox (see the video attached, the first version is with this line, the second without). What browser are you experiencing the misalignment with?

Hm, this misaligns the arrow for me on GNOME Web/Firefox (see the video attached, the first version is with this line, the second without). What browser are you experiencing the misalignment with?
Screencast From 2025-08-26 06-49-42.webm
52 KiB
david-swift marked this conversation as resolved
david-swift requested changes 2025-08-26 06:56:49 +02:00
Dismissed
david-swift left a comment
Owner
Copy Link

Thank you very much for this PR! I remember having seen the line break problem, even though I can't reproduce it right now, so thank you for the fix!

Thank you very much for this PR! I remember having seen the line break problem, even though I can't reproduce it right now, so thank you for the fix!
Tortellini commented 2025-08-26 07:16:00 +02:00
Author
Contributor
Copy Link

Ah I believe the misalignment might've been caused by font changes. I'll test it out when I'm able! I'm using the Orion browser on Webkit

Ah I believe the misalignment might've been caused by font changes. I'll test it out when I'm able! I'm using the Orion browser on Webkit
Tortellini added 1 commit 2025-08-26 09:04:46 +02:00
david-swift approved these changes 2025-08-26 12:23:40 +02:00
david-swift left a comment
Owner
Copy Link

Thank you very much for your contribution!

Thank you very much for your contribution!
david-swift merged commit bcdfbaf5f8 into main 2025-08-26 12:23:55 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
david-swift
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
sprint-1
sprint-2
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: david-swift/duckling#9
No description provided.
Delete Branch "Tortellini/duckling:fix-extra-linebreak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?