marquiskurt/adwaita-swift
1
0
Fork 0
forked from aparoksha/adwaita-swift
Code Pull Requests Activity

Slightly improve performance of State

Browse Source
This commit is contained in:
david-swift 2024-04-21 07:27:52 +02:00
parent 795410ded0
commit 7748668f4b
2 changed files with 31 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Sources/Adwaita/Model/Data Flow/Binding.swift
View File

@ -122,7 +122,7 @@ extension Binding where Value: MutableCollection {
public subscript(safe index: Value.Index?, default defaultValue: Value.Element) -> Binding<Value.Element> { public subscript(safe index: Value.Index?, default defaultValue: Value.Element) -> Binding<Value.Element> {
.init { .init {
if let index, wrappedValue.indices.contains(index) { if let index, wrappedValue.indices.contains(index) {
return wrappedValue[index] ?? defaultValue return wrappedValue[index]
} }
return defaultValue return defaultValue
} set: { newValue in } set: { newValue in

33
Sources/Adwaita/Model/Data Flow/State.swift
View File

@ -72,7 +72,7 @@ public struct State<Value>: StateProtocol {
/// - wrappedValue: The wrapped value. /// - wrappedValue: The wrapped value.
/// - forceUpdates: Whether to force update all available views when the property gets modified. /// - forceUpdates: Whether to force update all available views when the property gets modified.
public init(wrappedValue: Value, forceUpdates: Bool = false) { public init(wrappedValue: Value, forceUpdates: Bool = false) {
content = .init(storage: .init(value: wrappedValue)) content = .init(initialValue: wrappedValue)
self.forceUpdates = forceUpdates self.forceUpdates = forceUpdates
} }
@ -80,14 +80,41 @@ public struct State<Value>: StateProtocol {
public class Content { public class Content {
/// The storage. /// The storage.
public var storage: Storage public var storage: Storage {
get {
if let internalStorage {
return internalStorage
}
let storage = Storage(value: initialValue)
internalStorage = storage
return storage
}
set {
internalStorage = newValue
}
}
/// The internal storage.
var internalStorage: Storage?
/// The initial value.
private var initialValue: Value
/// Initialize the content. /// Initialize the content.
/// - Parameter storage: The storage. /// - Parameter storage: The storage.
@available(*, deprecated, message: "Use a safer initializer instead")
public init(storage: Storage) { public init(storage: Storage) {
// swiftlint:disable force_cast
let initialValue = storage.value as! Value
// swiftlint:enable force_cast
self.initialValue = initialValue
self.storage = storage self.storage = storage
} }
/// Initialize the content.
/// - Parameter initialValue: The initial value.
public init(initialValue: Value) {
self.initialValue = initialValue
}
} }
/// A class storing the value. /// A class storing the value.
@ -156,7 +183,7 @@ extension State where Value: Codable {
/// ///
/// The folder path will be appended to the XDG data home directory. /// The folder path will be appended to the XDG data home directory.
public init(wrappedValue: Value, _ key: String, folder: String? = nil, forceUpdates: Bool = false) { public init(wrappedValue: Value, _ key: String, folder: String? = nil, forceUpdates: Bool = false) {
content = .init(storage: .init(value: wrappedValue)) content = .init(initialValue: wrappedValue)
self.forceUpdates = forceUpdates self.forceUpdates = forceUpdates
content.storage.key = key content.storage.key = key
content.storage.folder = folder content.storage.folder = folder