Simpler array bounds checking #7

2024-03-26T14:27:08+01:00

ZevEisenberg commented

2024-03-26 14:27:08 +01:00

(Migrated from github.com)

Steps

Add your name or username and a link to your GitHub profile into the Contributors.md file.
Build the project on your machine. If it does not compile, fix the errors.
Describe the purpose and approach of your pull request below.
Submit the pull request. Thank you very much for your contribution!

Purpose

This is a slightly simpler and possibly more idiomatic way to check array bounds using the array's built-in indices collection.

Approach

See above.

## Steps - [x] Add your name or username and a link to your GitHub profile into the [Contributors.md][1] file. - [ ] Build the project on your machine. If it does not compile, fix the errors. - [x] Describe the purpose and approach of your pull request below. - [x] Submit the pull request. Thank you very much for your contribution! ## Purpose This is a slightly simpler and possibly more idiomatic way to check array bounds using the array's built-in `indices` collection. ## Approach See above. [1]: /Contributors.md

ZevEisenberg commented

2024-03-26 14:35:43 +01:00

(Migrated from github.com)

I wasn't able to build on my machine, possibly because I'm on a Mac?

david-swift (Migrated from github.com) approved these changes 2024-03-26 17:26:44 +01:00

david-swift (Migrated from github.com) left a comment

Thank you! Could you maybe share some information about your problem on macOS, maybe in the discussions? I tried this library on macOS the last time some months ago, and the build succeeded, so it probably isn't a general problem of the library itself, but one of the system/configuration.

ZevEisenberg commented

2024-06-23 05:44:01 +02:00

(Migrated from github.com)

Apologies for the delay! Here's a screenshot of the errors I see, and some detail on the first one in the build log. I'm assuming I need some dependency installed, but the readme didn't mention anything that I could see. I installed libadwaita via homebrew, but it didn't help.

Apologies for the delay! Here's a screenshot of the errors I see, and some detail on the first one in the build log. I'm assuming I need some dependency installed, but the readme didn't mention anything that I could see. I installed `libadwaita` via homebrew, but it didn't help. <img width="1512" alt="image" src="https://github.com/AparokshaUI/adwaita-swift/assets/464574/996736af-af7e-455e-9e9a-80e9da15f6a1">

david-swift commented

2024-06-23 08:14:53 +02:00

(Migrated from github.com)

This is probably the same problem as reported in https://github.com/AparokshaUI/adwaita-swift/issues/32. Unfortunately, we haven't yet been able to fix it (but it should work with swift run instead of Xcode's run button). Maybe you could try the steps in https://github.com/AparokshaUI/adwaita-swift/issues/11#issuecomment-2026804538, I don't know whether this helps (in general, I'd recommend installing Linux on the device or in a VM to work with Libadwaita).

This is probably the same problem as reported in https://github.com/AparokshaUI/adwaita-swift/issues/32. Unfortunately, we haven't yet been able to fix it (but it should work with `swift run` instead of Xcode's run button). Maybe you could try the steps in https://github.com/AparokshaUI/adwaita-swift/issues/11#issuecomment-2026804538, I don't know whether this helps (in general, I'd recommend installing Linux on the device or in a VM to work with Libadwaita).

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: aparoksha/adwaita-swift#7