aparoksha/adwaita-swift
3
7
Fork 5
Code Issues 19 Pull Requests Actions Releases 1 Activity

Add WrapMode to TextView/TextEditor #68

Merged
david-swift merged 3 commits from mlm/adwaita-swift:AddWrapMode into main 2025-08-27 13:36:22 +02:00
Conversation 1 Commits 3 Files Changed 3 +138 -47
mlm commented 2025-08-25 10:21:19 +02:00
Contributor
Copy Link

Steps

  • Build the project on your machine. If it does not compile, fix the errors.
  • Describe the purpose and approach of your pull request below.
  • Submit the pull request. Thank you very much for your contribution!

Purpose

Add support for the "GtkWrapModes" to TextEditor/TextView.

Approach

  • Wrapped the GtkWrapMode in a Swift enum WrapMode.
  • Added an extension to GtkWrapMode so it can be used as a rawValue in WrapMode.
  • Added a wrapMode() modifier to TextEditor to set the wrap mode.
  • Modified the update method to update the wrap mode as well.
## Steps - [x] Build the project on your machine. If it does not compile, fix the errors. - [x] Describe the purpose and approach of your pull request below. - [x] Submit the pull request. Thank you very much for your contribution! ## Purpose Add support for the "GtkWrapModes" to TextEditor/TextView. ## Approach - Wrapped the GtkWrapMode in a Swift enum `WrapMode`. - Added an extension to GtkWrapMode so it can be used as a rawValue in `WrapMode`. - Added a `wrapMode()` modifier to `TextEditor` to set the wrap mode. - Modified the `update` method to update the wrap mode as well.
mlm added 1 commit 2025-08-25 10:21:20 +02:00
Add WrapMode to TextView/TextEditor
Some checks failed
SwiftLint / SwiftLint (pull_request) Has been cancelled
Details
0af3864058
david-swift added 1 commit 2025-08-26 13:33:56 +02:00
Fix code style
All checks were successful
SwiftLint / SwiftLint (pull_request) Successful in 6s
Details
87b970d844
david-swift added 1 commit 2025-08-27 13:27:59 +02:00
Use more declarative approach for text editor
Some checks failed
SwiftLint / SwiftLint (pull_request) Has been cancelled
Details
4eb58b154c
david-swift commented 2025-08-27 13:36:09 +02:00
Owner
Copy Link

Thank you very much for this addition! This implementation works well.

I refactored the code to use the more declarative way for the widget definition. This comes with another advantage: While the old implementation updates properties such as the wrap mode whenever a state variable in one of the parent views updates, using the declarative approach ensures that the value is only being updated if it actually changes.

Thanks again!

Thank you very much for this addition! This implementation works well. I refactored the code to use the [more declarative way](https://meta.aparoksha.dev/documentation/meta/createbackend#A-Regular-Widget) for the widget definition. This comes with another advantage: While the old implementation updates properties such as the wrap mode whenever a state variable in one of the parent views updates, using the declarative approach ensures that the value is only being updated if it actually changes. Thanks again!
david-swift changed title from WIP: Add WrapMode to TextView/TextEditor to Add WrapMode to TextView/TextEditor 2025-08-27 13:36:15 +02:00
david-swift merged commit ebb2455fe1 into main 2025-08-27 13:36:22 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: aparoksha/adwaita-swift#68
No description provided.
Delete Branch "mlm/adwaita-swift:AddWrapMode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?